Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Logging broadcast #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

elpekenin
Copy link
Contributor

Description

I was developing a custom sendchar on my fork, sending XAP messages too, and the client kept crashing upon receiving those...

Ended up noticing a mismatch between fw's implementation and specification of the xap.Broadcast.Logging (which was the thing that lead me into sending a wrong payload)

There have been a couple of commits after that, which indicate that the header(and not first byte of payload) will actually be in charge of the task:

Thus, this is now the correct way of handling it...

Should perhaps wait a bit before merging, just to make 100% sure this will be the final way of doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant