Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was developing a custom
sendchar
on my fork, sending XAP messages too, and the client kept crashing upon receiving those...Ended up noticing a mismatch between fw's implementation and specification of the
xap.Broadcast.Logging
(which was the thing that lead me into sending a wrong payload)There have been a couple of commits after that, which indicate that the header(and not first byte of payload) will actually be in charge of the task:
Thus, this is now the correct way of handling it...
Should perhaps wait a bit before merging, just to make 100% sure this will be the final way of doing it.