Fix Azure endpoint properties and baseUrl computation #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edeandrea
force-pushed
the
azure-endpoint-props
branch
from
76ff91b to
206a325
Compare
geoand
reviewed
Jan 27, 2024
...ntime/src/main/java/io/quarkiverse/langchain4j/azure/openai/runtime/AzureOpenAiRecorder.java
Show resolved
Hide resolved
edeandrea
force-pushed
the
azure-endpoint-props
branch
from
8e9966f to
12e7426
Compare
|
@geoand I just pushed new commits for the re-naming of |
edeandrea
force-pushed
the
azure-endpoint-props
branch
from
12e7426 to
b5d3a9a
Compare
edeandrea
force-pushed
the
azure-endpoint-props
branch
from
b5d3a9a to
efb83e3
Compare
|
We should have a label for issues/prs that introduce breaking changes..... |
|
Indeed. I'll add some of the Quarkus labels here too |
|
I'm not sure why the JDK 17 build is failing. The failure is in some other module that I didn't touch. |
|
Yeah, it's a known bug that makes GraalVM hang |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Azure endpoint properties and how the baseUrl is computed.
See this issue comment.
Fixes #248