Add javadoc for ReleaseInformation #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartisk
reviewed
Jan 8, 2025
jmartisk
reviewed
Jan 8, 2025
gsmet
force-pushed
the
releaseinformation-javadoc
branch
from
aef0550 to
7e7bf8c
Compare
jmartisk
reviewed
Jan 8, 2025
| public boolean isMajor() { | ||
| return major; | ||
| } | ||
|
|
||
| /** | ||
| * @return whether the origin branch is the main branch (which is the default, should only be false when release the CR1 of a new LTS) |
There was a problem hiding this comment.
Hold on, but when releasing an LTS maintenance release, it will also be not from main, no?
There was a problem hiding this comment.
I added some clarification as this is only used when we create the branch so when releasing the CR1.
There was a problem hiding this comment.
I don't see any new changes here (apart from splitting the sentence into two lines)
There was a problem hiding this comment.
I think I will just point to the other method Javadoc to avoid duplication.
There was a problem hiding this comment.
Pushed something. Hopefully, it's good enough now. Otherwise, maybe we could have a quick call instead, might be faster :).
gsmet
force-pushed
the
releaseinformation-javadoc
branch
from
7e7bf8c to
58d0f3b
Compare
gsmet
force-pushed
the
releaseinformation-javadoc
branch
from
58d0f3b to
95013d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.