Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp AWS Quickstarts with DevServices #1356

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Revamp AWS Quickstarts with DevServices #1356

merged 1 commit into from
Jan 12, 2024

Conversation

scrocquesel
Copy link
Contributor

@scrocquesel scrocquesel commented Dec 1, 2023 •
edited
Loading

Check list:

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has integration/native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • for new quickstart, is located in the directory component-quickstart
  • for new quickstart, is added to the root pom.xml and README.md

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@scrocquesel scrocquesel marked this pull request as ready for review December 6, 2023 21:34
@scrocquesel
Copy link
Contributor Author

/review @gsmet

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
gsmet
gsmet requested changes Dec 12, 2023
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that but changes to the Dockerfiles look incorrect.

amazon-dynamodb-quickstart/src/main/docker/Dockerfile.jvm Outdated Show resolved Hide resolved
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Dec 12, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@scrocquesel scrocquesel requested a review from gsmet December 12, 2023 21:43
@scrocquesel
Copy link
Contributor Author

@gsmet kind reminder

gsmet
gsmet approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it slipped, merging now.

Thanks for this awesome work!

@gsmet gsmet merged commit db254d0 into quarkusio:development Jan 12, 2024
2 checks passed
@scrocquesel scrocquesel deleted the upgrade_quarkus_aws branch January 12, 2024 18:51
@scrocquesel scrocquesel mentioned this pull request Jan 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scrocquesel @gsmet