Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated webauthn code #1470

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Updated webauthn code #1470

merged 2 commits into from
Dec 6, 2024

Conversation

FroMage
Copy link
Member

@FroMage FroMage commented Oct 25, 2024

This is the quickstarts part of quarkusio/quarkus#44105

This comment has been minimized.

@FroMage
Copy link
Member Author

FroMage commented Nov 14, 2024

Redone after many changes in webauthn4j PR

This comment has been minimized.

This comment has been minimized.

@FroMage
Copy link
Member Author

FroMage commented Dec 6, 2024

Let's see if this compiles now that the PR is merged in main.

@geoand
Copy link
Collaborator

geoand commented Dec 6, 2024

Should we merge this? Quarkus main CI seems to be failing with it

Copy link

quarkus-bot bot commented Dec 6, 2024

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit 8604794.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@sberyozkin sberyozkin self-requested a review December 6, 2024 10:48
@sberyozkin sberyozkin merged commit 21da529 into quarkusio:development Dec 6, 2024
2 checks passed
@FroMage
Copy link
Member Author

FroMage commented Dec 6, 2024

Should we merge this? Quarkus main CI seems to be failing with it

With this PR, or without this PR?

@FroMage FroMage deleted the webauthn4j branch December 6, 2024 10:57
@geoand
Copy link
Collaborator

geoand commented Dec 6, 2024

🤦🏽

I meant without it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants