Migrate UI from Angular to React #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet! And once done we should move this to quarkusio/quarkus-super-heroes#290 |
holly-cummins
force-pushed
the
migrate-to-react
branch
from
23b9a93 to
0121439
Compare
|
@holly-cummins I have no UI skills and would be a terrible reviewer. Does anybody in the team have more knowledge and would like to review it ? cc @edeandrea @cescoffier @geoand ? |
I have even less :) |
holly-cummins
force-pushed
the
migrate-to-react
branch
2 times, most recently
from
4777ee4 to
d3940c6
Compare
holly-cummins
force-pushed
the
migrate-to-react
branch
from
d3940c6 to
b40f15d
Compare
|
🙈 The PR is closed and the preview is expired. |
|
I can spell typescript..... |
|
Ok, since no one has opinions about this and I'm fairly confident that (a) the code is reasonable and (b) I've replicated the previous functionality, I will just merge. |
|
Congrats @holly-cummins !!! You just achieved a Yolo Merge: "Merged own pull request without code review" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What’s in this change:
This change looks big, but almost all of it is deletions. The React app is significantly smaller than its Angular equivalent.
I had to fuss with the css a bit, because I removed material UI and bootstrap. Having them as well as patternfly seemed like an overload of cascading styles.
I have made some changes to the behaviour of the front end when the back end isn’t available. Instead of showing unpopulated UI features, it will explicitly warn that the other services are missing.
I also fixed a missing icon for the narration button.
One thing I have not done is wired the UI tests into the Java test execution. I’ll do that in a follow-up PR, unless we decide we don’t want to do that, in which case I’ll just include them in the
build.yml.We won’t feel really safe accepting dependabot PRs until that’s done.