Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Load to Quarkus App #494

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

karesti
Copy link
Member

@karesti karesti commented Mar 7, 2024

I have done in this PR:

  • Convert to a Quarkus App
  • Use Picocli. In reality a simple Quarkus main would be enough if the app remains this simple
  • Change the code to use RestClient instead of custom rest api calls
  • 3 schedulers

Things to discuss here:

  • I'm unable to stop the app when we are in dev mode
  • Do we want to enhance this picocli application with more options ? Or should we simply have a Quarkus Main

Closes #100

@karesti
Copy link
Member Author

karesti commented Mar 7, 2024

@agoncal @holly-cummins questions here

@karesti karesti force-pushed the picocli-app branch 9 times, most recently from 64c53a7 to f499a0f Compare March 8, 2024 13:39
@karesti karesti marked this pull request as ready for review June 6, 2024 07:58
@holly-cummins
Copy link
Collaborator

Oh noo, this got opened, and then ignored! I'm totally unable to answer these questions, but @geoand may be able to.

@geoand
Copy link
Collaborator

geoand commented Sep 19, 2024

I'm unable to stop the java class and I tried to find a proper way with picocli and I was unable to find one.

You mean you can't stop the running application?

RestClient methods should be "Uni" "Multi" for reactive ?

correct

@karesti
Copy link
Member Author

karesti commented Sep 19, 2024

@holly-cummins I'm goign to retake this :)

@karesti karesti force-pushed the picocli-app branch 3 times, most recently from 46bf7b7 to 4e74422 Compare October 30, 2024 12:27
@karesti
Copy link
Member Author

karesti commented Oct 30, 2024

@geoand @holly-cummins I rebased the code and pushed some changes

@karesti karesti force-pushed the picocli-app branch 6 times, most recently from 004f491 to c5e65ef Compare October 31, 2024 11:11
@karesti
Copy link
Member Author

karesti commented Oct 31, 2024

@geoand I removed the native build for the cli. After playing around and testing many things, I think https://github.com/datafaker-net/datafaker is not graalvm compatible now, and to be used inside a native quarkus app, I feel it needs it's own extension

Copy link

github-actions bot commented Oct 31, 2024

😭 Deploy PR Preview failed.

@geoand
Copy link
Collaborator

geoand commented Oct 31, 2024

Interesting!

@geoand
Copy link
Collaborator

geoand commented Oct 31, 2024

LGTM, @holly-cummins WDYT?

Copy link
Collaborator

@holly-cummins holly-cummins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for my comment about the project name. If we stick with the original name the diff might be smaller/more readable, as a bonus.

Do we want to add an example of how to build and invoke the new cli? (Or is that the same as before and it's already in the docs?)

@karesti
Copy link
Member Author

karesti commented Nov 4, 2024

Do

I added it in the docs

@karesti
Copy link
Member Author

karesti commented Nov 4, 2024

@holly-cummins @geoand I reported the changes

@geoand
Copy link
Collaborator

geoand commented Nov 7, 2024

+1 from me

@cescoffier
Copy link
Member

Looks good to me.

@holly-cummins
Copy link
Collaborator

Thanks, Katia!

@holly-cummins holly-cummins merged commit 7293836 into quarkusio:main Nov 7, 2024
6 checks passed
@karesti karesti deleted the picocli-app branch November 7, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn Load Super Heroes into a Quarkus + PicoCLI app
4 participants