Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not comment on work items if nothing was torn down #528

Merged

Conversation

holly-cummins
Copy link
Collaborator

Even though previews are currently broken (#443), every PR gets a preview teardown message. Obviously, the ideal thing to do is to fix previews, but independent of that, the build should not comment on PRs if nothing actually got torn down.

Copy link

😭 Deploy PR Preview failed.

@holly-cummins holly-cummins merged commit 649faed into quarkusio:main May 23, 2024
6 checks passed
@holly-cummins holly-cummins deleted the reduce-preview-teardown-noise branch May 23, 2024 07:52
@holly-cummins
Copy link
Collaborator Author

Tada! No comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant