Migrate extension Config to @ConfigMapping

[gastaldi]

/cc @geoand @gsmet @holly-cummins @radcortez

[gastaldi]

It fails with

Caused by: java.lang.ClassNotFoundException: io.quarkus.workshop.superheroes.version.deployment.VersionConfig
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
	at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:533)
	at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:481)
	at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:533)
	at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:481)
	at io.quarkus.runtime.configuration.AbstractConfigBuilder.withMapping(AbstractConfigBuilder.java:64)
	... 21 more

Not sure what's causing this, investigating

[dmlloyd]

Run time config interfaces must be in the runtime artifact, not the deployment artifact; could it be that simple?

[radcortez]

That is the most likely issue :)

[gastaldi]

Weird how that always worked with @configroot, but that makes sense

[github-actions]

😭 Deploy PR Preview failed.

[dmlloyd]

Previously it was not explicitly bound to a phase, so I guess it defaulted to "build time", which is probably why it worked before.

[geoand]

+1

[gastaldi]

Looks like it's ready to be merged now