Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
s/expecErr/expectErr/
  • Loading branch information
Joe Bowman authored Oct 19, 2023
1 parent db3369c commit 18035de
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions x/interchainstaking/keeper/msg_server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ func (suite *KeeperTestSuite) TestGovCloseChannel() {
testCase := []struct {
name string

Check failure on line 504 in x/interchainstaking/keeper/msg_server_test.go

View workflow job for this annotation

GitHub Actions / lint

File is not `gci`-ed with --skip-generated -s standard -s default -s blank -s dot -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) -s prefix(github.com/cometbft/cometbft) -s prefix(github.com/cosmos/ibc-go) -s prefix(github.com/quicksilver-zone/quicksilver) --custom-order (gci)
malleate func(suite *KeeperTestSuite) *icstypes.MsgGovCloseChannel
expecErr error
expectErr error
}{
{
name: "invalid authority",
Expand All @@ -514,7 +514,7 @@ func (suite *KeeperTestSuite) TestGovCloseChannel() {
Authority: testAddress,
}
},
expecErr: govtypes.ErrInvalidSigner,
expectErr: govtypes.ErrInvalidSigner,
},
{
name: "capability not found",
Expand All @@ -527,7 +527,7 @@ func (suite *KeeperTestSuite) TestGovCloseChannel() {
Authority: sdk.MustBech32ifyAddressBytes(sdk.GetConfig().GetBech32AccountAddrPrefix(), k.AccountKeeper.GetModuleAddress(govtypes.ModuleName)),
}
},
expecErr: capabilitytypes.ErrCapabilityNotFound,
expectErr: capabilitytypes.ErrCapabilityNotFound,
},
{
name: "invalid connection state",
Expand All @@ -542,7 +542,7 @@ func (suite *KeeperTestSuite) TestGovCloseChannel() {
Authority: sdk.MustBech32ifyAddressBytes(sdk.GetConfig().GetBech32AccountAddrPrefix(), k.AccountKeeper.GetModuleAddress(govtypes.ModuleName)),
}
},
expecErr: connectiontypes.ErrInvalidConnectionState,
expectErr: connectiontypes.ErrInvalidConnectionState,
},
{
name: "closes an ICA channel success",
Expand All @@ -558,7 +558,7 @@ func (suite *KeeperTestSuite) TestGovCloseChannel() {
Authority: sdk.MustBech32ifyAddressBytes(sdk.GetConfig().GetBech32AccountAddrPrefix(), k.AccountKeeper.GetModuleAddress(govtypes.ModuleName)),
}
},
expecErr: nil,
expectErr: nil,
},
}
for _, tc := range testCase {
Expand All @@ -571,8 +571,8 @@ func (suite *KeeperTestSuite) TestGovCloseChannel() {
ctx := suite.chainA.GetContext()

_, err := msgSrv.GovCloseChannel(ctx, msg)
if tc.expecErr != nil {
suite.ErrorIs(tc.expecErr, err)
if tc.expectErr != nil {
suite.ErrorIs(tc.expectErr, err)
return
}
suite.NoError(err)
Expand Down

0 comments on commit 18035de

Please sign in to comment.