refactor so we do error checking before creating protocol data (#877)

quicksilver-zone · Dec 11, 2023 · bd797bc · bd797bc
1 parent a809c3e
commit bd797bc
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/x/participationrewards/keeper/proposal_handler.go b/x/participationrewards/keeper/proposal_handler.go
@@ -8,8 +8,6 @@ import (
 
 // HandleAddProtocolDataProposal is a handler for executing a passed add protocol data proposal.
 func HandleAddProtocolDataProposal(ctx sdk.Context, k *Keeper, p *types.AddProtocolDataProposal) error {
-	protocolData := types.NewProtocolData(p.Type, p.Data)
-
 	if err := p.ValidateBasic(); err != nil {
 		return err
 	}
@@ -28,6 +26,8 @@ func HandleAddProtocolDataProposal(ctx sdk.Context, k *Keeper, p *types.AddProto
 		return err
 	}
 
+	protocolData := types.NewProtocolData(p.Type, p.Data)
+
 	k.SetProtocolData(ctx, pd.GenerateKey(), protocolData)
 
 	return nil