Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for HandleRedeemTokens #661

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Conversation

neitdung
Copy link
Contributor

@neitdung neitdung commented Oct 3, 2023

1. Summary

Fixes #617

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

  • Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #661 (780e184) into main (64173b8) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
+ Coverage   13.85%   13.87%   +0.01%     
==========================================
  Files         243      243              
  Lines       63047    63047              
==========================================
+ Hits         8735     8745      +10     
+ Misses      53602    53590      -12     
- Partials      710      712       +2     
Flag Coverage Δ
unittests 13.87% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Contributor

@ThanhNhann ThanhNhann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank @neitdung

@ThanhNhann ThanhNhann merged commit 1193fa6 into main Oct 26, 2023
12 checks passed
@ThanhNhann ThanhNhann deleted the neitdung/test-redeem-tokens branch October 26, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants