test for HandleCompleteSend #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DongLieu
requested review from
joe-bowman,
ajansari95,
muku314115,
ThanhNhann,
faddat,
sontrinh16 and
anhductn2001
as code owners
joe-bowman
reviewed
Oct 8, 2023
| ToAddress: zone.DelegationAddress.Address, | ||
| Amount: sdk.NewCoins(sdk.NewCoin(zone.BaseDenom, sdk.NewInt(1_000_000))), | ||
| }, | ||
| memo: fmt.Sprintf("unbondSend/%d", complete.Unix()), |
There was a problem hiding this comment.
this is an invlaid memo for a send from deposit -> delegation (it will probably work, but the unbondSend/xxxx memo is always from delegate -> recipient of unbonded tokens)
joe-bowman
reviewed
Oct 8, 2023
Codecov Report
@@ Coverage Diff @@
## main #672 +/- ##
==========================================
+ Coverage 13.97% 14.00% +0.03%
==========================================
Files 243 243
Lines 63049 63049
==========================================
+ Hits 8812 8832 +20
+ Misses 53525 53503 -22
- Partials 712 714 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Requires linitng. |
|
Ok! |
ThanhNhann
reviewed
Oct 25, 2023
| @@ -2862,6 +2863,78 @@ func (suite *KeeperTestSuite) TestGetValidatorForToken() { | |||
| } | |||
| } | |||
|
|
|||
| func (suite *KeeperTestSuite) TestHandleCompleteSend() { | |||
| suite.Run("TestHandleCompleteSend", func() { | |||
There was a problem hiding this comment.
Hey plz move this setup after line 2917 so we can know the name of each test case when we can run the testing
anhductn2001
previously approved these changes
Oct 27, 2023
ThanhNhann
reviewed
Oct 27, 2023
DongLieu
dismissed stale reviews from anhductn2001 and joe-bowman
via
c228784
Co-authored-by: Nguyen Thanh Nhan <[email protected]>
Co-authored-by: Nguyen Thanh Nhan <[email protected]>
Co-authored-by: Nguyen Thanh Nhan <[email protected]>
|
Ok |
ThanhNhann
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Summary
Fixes #617
2.Type of change
3. Implementation details
4. How to test/use
5. Checklist
6. Limitations (optional)
7. Future Work (optional)