fix: weird reslicing in SetForValoper - fixes #806 #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-bowman
requested review from
ThanhNhann,
faddat,
sontrinh16 and
anhductn2001
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #812 +/- ##
==========================================
+ Coverage 61.96% 61.98% +0.01%
==========================================
Files 172 172
Lines 14028 14033 +5
==========================================
+ Hits 8693 8698 +5
Misses 4596 4596
Partials 739 739
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
checking now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Summary
Fixes #806
Improves performance and reduces complexity in ValidatorIntents.SetForValoper.
2.Type of change
3. Implementation details
Replace in place, instead of remove + append + sort.