Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proto dockerfile #870

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Update proto dockerfile #870

merged 4 commits into from
Dec 12, 2023

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Dec 11, 2023

1. Summary

We should host the proto build image on github

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

Add a github action

4. How to test/use

Github action should succeed and we should get an artifact.

@faddat faddat requested a review from joe-bowman as a code owner December 11, 2023 10:06
@faddat faddat marked this pull request as draft December 11, 2023 10:25
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #870 (635e044) into main (d6fae3b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #870   +/-   ##
=======================================
  Coverage   61.87%   61.87%           
=======================================
  Files         172      172           
  Lines       14080    14080           
=======================================
  Hits         8712     8712           
  Misses       4623     4623           
  Partials      745      745           
Flag Coverage Δ
unittests 61.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

joe-bowman
joe-bowman previously approved these changes Dec 11, 2023
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@faddat faddat marked this pull request as ready for review December 12, 2023 13:23
@faddat faddat changed the title Use github hosting for the proto builder Update proto dockerfile Dec 12, 2023
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@joe-bowman joe-bowman merged commit 1e1e841 into main Dec 12, 2023
12 checks passed
@joe-bowman joe-bowman deleted the faddat-patch-8 branch December 12, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants