fix: super defensive checks in ValAddressFromBech32 and AccAddressFromBech32 #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #872 +/- ##
==========================================
+ Coverage 61.87% 61.88% +0.01%
==========================================
Files 172 172
Lines 14079 14085 +6
==========================================
+ Hits 8711 8717 +6
Misses 4623 4623
Partials 745 745
Flags with carried forward coverage won't be shown. Click here to find out more.
|
added 2 commits
December 12, 2023 10:47
joe-bowman
force-pushed
the
855-defensive-checks
branch
from
279305d to
1b78cad
Compare
faddat
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Summary
Fixes #855
Adds super defensive checks in case AddressFromBech32 is ever changed.
2.Type of change
3. Implementation details
Ensure we always explicitly return nil on error.