Defensive checks callbacks #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-bowman
added
module: interchainstaking
module: interchainquery
module: participationrewards
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
==========================================
- Coverage 61.93% 61.89% -0.04%
==========================================
Files 172 172
Lines 14051 14052 +1
==========================================
- Hits 8703 8698 -5
- Misses 4606 4612 +6
Partials 742 742
Flags with carried forward coverage won't be shown. Click here to find out more.
|
faddat
approved these changes
Dec 11, 2023
joe-bowman
commented
Dec 24, 2023
| @@ -49,6 +49,9 @@ func (k *Keeper) CallbackHandler() Callbacks { | |||
|
|
|||
| // Call calls callback handler. | |||
| func (c Callbacks) Call(ctx sdk.Context, id string, args []byte, query icqtypes.Query) error { | |||
| if c.Has(id) { | |||
There was a problem hiding this comment.
this should be negated. arse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Summary
Fixes #842
Adds additional check to avoid nil pointer.
2.Type of change