Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional defensive checks #878

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Additional defensive checks #878

merged 5 commits into from
Dec 12, 2023

Conversation

joe-bowman
Copy link
Contributor

1. Summary

Partially resolves #848

Adds some defensive assertions, notably around use of isZero vs !isPositive when negative values are not permitted.

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)

@joe-bowman joe-bowman requested a review from faddat as a code owner December 11, 2023 17:06
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #878 (b3943f5) into main (bd797bc) will increase coverage by 0.00%.
The diff coverage is 77.33%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #878   +/-   ##
=======================================
  Coverage   61.93%   61.94%           
=======================================
  Files         172      172           
  Lines       14051    14073   +22     
=======================================
+ Hits         8703     8717   +14     
- Misses       4606     4612    +6     
- Partials      742      744    +2     
Flag Coverage Δ
unittests 61.94% <77.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
x/interchainstaking/keeper/delegation.go 92.27% <100.00%> (ø)
x/interchainstaking/keeper/intent.go 76.92% <100.00%> (ø)
x/participationrewards/keeper/distribution.go 68.32% <0.00%> (ø)
x/interchainstaking/keeper/redemptions.go 78.42% <78.57%> (-1.49%) ⬇️

@joe-bowman joe-bowman merged commit 2d11ef2 into main Dec 12, 2023
13 checks passed
@joe-bowman joe-bowman deleted the 848-defensive-checks branch December 12, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants