Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deps #899

Closed
wants to merge 4 commits into from
Closed

update deps #899

wants to merge 4 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Dec 14, 2023

1. Summary

This fixes the issue with the web ui not building, in advance of bringing in @chalabi2's work.

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

yarn update

4. How to test/use

ci should pass

@faddat faddat requested a review from joe-bowman as a code owner December 14, 2023 08:04
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #899 (d9acea5) into main (fe542f6) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head d9acea5 differs from pull request most recent head ff2fff1. Consider uploading reports for the commit ff2fff1 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #899   +/-   ##
=======================================
  Coverage   61.87%   61.87%           
=======================================
  Files         172      172           
  Lines       14080    14080           
=======================================
  Hits         8712     8712           
  Misses       4623     4623           
  Partials      745      745           
Flag Coverage Δ
unittests 61.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@joe-bowman
Copy link
Contributor

Should Build WebUI task pass now? It is not!

@chalabi2
Copy link
Collaborator

I wouldn't bother Jacob as my web ui now uses bun. Will merge it today

@faddat
Copy link
Contributor Author

faddat commented Dec 16, 2023

@chalabi2 I'll close this and call you later to work out your merge sir. Thank you for your work.

@faddat faddat closed this Dec 16, 2023
@joe-bowman joe-bowman deleted the faddat/fix-web-ui branch December 19, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants