update react #915
Closed
update react #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalabi2
previously approved these changes
Dec 19, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #915 +/- ##
=======================================
Coverage 61.87% 61.87%
=======================================
Files 172 172
Lines 14080 14080
=======================================
Hits 8712 8712
Misses 4623 4623
Partials 745 745
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@chalabi2 can you try this on your local machine? For me, it works fine locally.... |
|
@faddat this introduces breaking changes |
|
@chalabi2 the PR is me trying to fix them & learn what breaks :). Feel free to ignore drafts :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Summary
Updates to the latest react.
Should be merged after #913
2.Type of change
3. Implementation details
4. How to test/use
5. Checklist
6. Limitations (optional)
7. Future Work (optional)