Clean up outdated applications (bootstrap-pull-request) #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int128
force-pushed
the
int128/cleanup-outdated-applications
branch
from
27427b2 to
d174cf5
Compare
int128
changed the title
int128
commented
Oct 25, 2023
| const readContentOrNull = async (f: string): Promise<string | null> => | ||
| await catchENOENT(async () => (await fs.readFile(f)).toString()) | ||
|
|
||
| const catchENOENT = async <T>(f: () => Promise<T>): Promise<T | null> => { |
There was a problem hiding this comment.
Refactoring to extract catch.
|
|
||
| const readContent = async (filename: string) => (await fs.readFile(filename)).toString() | ||
|
|
||
| describe('copyServicesFromPrebuilt', () => { | ||
| const createEmptyDirectory = async () => await fs.mkdtemp(path.join(os.tmpdir(), 'bootstrap-pull-request-')) |
There was a problem hiding this comment.
Refactoring to extract the common function.
| // deleteExistingApplications() deletes the existing applications, and then | ||
| // copyServicesFromPrebuilt() recreates the applications. | ||
| await deleteExistingApplications(inputs) | ||
| await copyServicesFromPrebuilt(inputs) |
There was a problem hiding this comment.
copyServicesFromPrebuilt is the original function.
In this pull request, I have added deleteExistingApplications.
semnil
approved these changes
Oct 25, 2023
panicboat
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem to solve
When a service has been removed from the prebuilt branch, it will remain in the existing namespace branches. It may waste the infrastructure cost.
For example,
How to solve
Clean up the outdated applications before copying the services.