Refactor git-push-service action #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int128
commented
Jan 7, 2025
Comment on lines
+43
to
+48
| annotations: { | ||
| ...parseApplicationAnnotations(inputs.applicationAnnotations), | ||
| 'github.ref': inputs.currentRef, | ||
| 'github.sha': inputs.currentSha, | ||
| 'github.action': 'git-push-service', | ||
| }, |
There was a problem hiding this comment.
Moved from:
monorepo-deploy-actions/git-push-service/src/run.ts
Lines 71 to 76 in 05ab919
| core.info(`writing to ${destination}`) | ||
| const content = generateApplicationManifest(application) | ||
| await fs.writeFile(destination, content) | ||
| const parseApplicationAnnotations = (applicationAnnotations: string[]): Record<string, string> => { |
There was a problem hiding this comment.
Moved from:
monorepo-deploy-actions/git-push-service/src/application.ts
Lines 72 to 80 in 05ab919
Comment on lines
+36
to
+67
| const application = { | ||
| apiVersion: 'argoproj.io/v1alpha1', | ||
| kind: 'Application', | ||
| metadata: { | ||
| name: `${inputs.namespace}--${inputs.service}`, | ||
| namespace: 'argocd', | ||
| finalizers: ['resources-finalizer.argocd.argoproj.io'], | ||
| annotations: { | ||
| ...parseApplicationAnnotations(inputs.applicationAnnotations), | ||
| 'github.ref': inputs.currentRef, | ||
| 'github.sha': inputs.currentSha, | ||
| 'github.action': 'git-push-service', | ||
| }, | ||
| }, | ||
| spec: { | ||
| project: inputs.project, | ||
| source: { | ||
| repository: inputs.destinationRepository, | ||
| branch: inputs.branch, | ||
| repoURL: `https://github.com/${inputs.destinationRepository}.git`, | ||
| targetRevision: inputs.branch, | ||
| path: `services/${inputs.service}`, | ||
| }, | ||
| destination: { | ||
| server: `https://kubernetes.default.svc`, | ||
| namespace: inputs.namespace, | ||
| }, | ||
| annotations: inputs.applicationAnnotations, | ||
| syncPolicy: { | ||
| automated: { | ||
| prune: true, | ||
| }, | ||
| }, | ||
| }, | ||
| inputs.workspace, | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
Moved from:
monorepo-deploy-actions/git-push-service/src/application.ts
Lines 46 to 71 in 05ab919
int128
commented
Jan 7, 2025
| } | ||
|
|
||
| export const arrangeManifests = async (inputs: Inputs): Promise<void> => { | ||
| return await arrangeServiceManifests(inputs) | ||
| export const writeManifests = async (inputs: Inputs): Promise<void> => { |
There was a problem hiding this comment.
Rename the functions to write prefix.
44smkn
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will apply the refactoring. There is no specification change.