Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizations around deleting windows that eliminate the need to deserialize the window key before deletion.
WindowedRocksDBPartitionTransaction.delete_window
has been removed because it depended on deserialized input parameters. Deleting windows will now be handled by a lower-levelPartitionTransaction.delete
method, which now accepts only byte keys.WindowedRocksDBPartitionTransaction.delete_windows
internally will not useget_windows
but a lower-level_get_items
method which returns serialized keys.WindowedRocksDBPartitionTransaction.expire_windows
no longer handles deleting windows. It has been ultimately delegated to the outer scope, specifically theprocess_window
method.