Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize window deletion #707

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

gwaramadze
Copy link
Contributor

@gwaramadze gwaramadze commented Jan 14, 2025

Optimizations around deleting windows that eliminate the need to deserialize the window key before deletion.

  1. WindowedRocksDBPartitionTransaction.delete_window has been removed because it depended on deserialized input parameters. Deleting windows will now be handled by a lower-level PartitionTransaction.delete method, which now accepts only byte keys.
  2. WindowedRocksDBPartitionTransaction.delete_windows internally will not use get_windows but a lower-level _get_items method which returns serialized keys.
  3. WindowedRocksDBPartitionTransaction.expire_windows no longer handles deleting windows. It has been ultimately delegated to the outer scope, specifically the process_window method.

@gwaramadze gwaramadze added enhancement New feature or request draft Work in progress - no need to review yet labels Jan 14, 2025
@gwaramadze gwaramadze force-pushed the fix/optimize-window-deletion branch 2 times, most recently from 006c5b9 to 02e8fc7 Compare January 17, 2025 13:35
Base automatically changed from feature/collections to main January 17, 2025 14:42
@gwaramadze gwaramadze force-pushed the fix/optimize-window-deletion branch from 02e8fc7 to 1504321 Compare January 17, 2025 17:13
@gwaramadze gwaramadze marked this pull request as ready for review January 17, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft Work in progress - no need to review yet enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant