Implement tumbling_count_window #709
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is dictated by the legacy structure of the code. Method `delete` requires prefix and remainder of a key to be passed separately and refactoring this is a larger effort.
The helper method `_get_items` is more in line with a native rocksdict behavior where the lower band is inclusive and the upper exclusive. The inverted characteristics known from an upper scope's `get_windows` method are guaranteed by key deserialization and condition: `start_from_ms < start <= start_to_ms`. In the future, we should refactor the code to remove this condition and rely on `_get_items` inclusivity/exclusivity characteristics.
It is a shortcut to empty results if the given start timestamp is higher than the end timestamp. There are currently use cases in the code that may lead to this and there is no easy way to avoid it. The shortcut is required to avoid unexpected behaviors with negative integers converted to int64 encoded bytes.
Removing duplicated link
Co-authored-by: Tim Sawicki <[email protected]>
Co-authored-by: daniil-quix <[email protected]>
quentin-quix
force-pushed
the
quent/couting-window
branch
from
89c3ac0 to
d9075c8
Compare
quentin-quix
force-pushed
the
quent/couting-window
branch
from
d9075c8 to
65bf164
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.