Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Model.toString() #75

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

petebankhead
Copy link
Member

No description provided.

@alanocallaghan
Copy link
Collaborator

If I'm parsing this right, it means the toString changes from just model name to [parentdir]/[name]-[version], leaving out parentdir or version if null? lgtm, although will conflict with #76

@alanocallaghan
Copy link
Collaborator

Ah, no, insert the directory name if it's not the model, I see

@alanocallaghan alanocallaghan merged commit a42f781 into qupath:main Sep 10, 2024
@petebankhead petebankhead deleted the improved-tostring branch September 10, 2024 10:44
@petebankhead
Copy link
Member Author

petebankhead commented Sep 10, 2024

You didn't really have to merge this if it doesn't fit with the versioning plans :)

But yeah, the name stored within rdf.yaml might not match the directory name, and so there would be subtle clashes causing models to be dropped due to names not being unique... despite looking unique in the directory.

Also, it's not obvious to the user that the name in rdf.yaml is being used - and so they might rename the model directory and hope that is sufficient.... but it is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants