Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audio settings button missing on some devices #3036

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Dec 28, 2024

This patch fixes the audio settings button going missing on some devices
(devices with width of 320dp, for example). It sets a width per button
to ensure that everything fits, and assigns weight of 1 to each so that
the buttons can have more space if the space available is more.

This patch fixes the audio settings button going missing on some devices
(devices with width of 320dp, for example). It sets a width per button
to ensure that everything fits, and assigns weight of 1 to each so that
the buttons can have more space if the space available is more.
@ahmedre
Copy link
Contributor Author

ahmedre commented Dec 28, 2024

before (Nexus S emulator in portrait)
no_settings_bug

after (Nexus S emulator in portrait)
Screenshot_20241228_234253

after (Nexus S emulator in landscape)
Screenshot_20241228_234347

after (Pixel 9 Pro emulator in landscape)
Screenshot_20241228_234219

Copy link

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │           compressed           │          uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
      dex │  24.1 MiB │  24.1 MiB │ +700 B │  74.8 MiB │  74.8 MiB │ +3 KiB 
     arsc │   2.7 MiB │   2.7 MiB │    0 B │   2.7 MiB │   2.7 MiB │    0 B 
 manifest │   5.8 KiB │   5.8 KiB │    0 B │    28 KiB │    28 KiB │    0 B 
      res │   1.7 MiB │   1.7 MiB │    0 B │     2 MiB │     2 MiB │    0 B 
   native │  18.8 KiB │  18.8 KiB │    0 B │  36.5 KiB │  36.5 KiB │    0 B 
    asset │ 404.2 KiB │ 404.2 KiB │    0 B │ 678.6 KiB │ 678.6 KiB │    0 B 
    other │ 218.4 KiB │ 218.4 KiB │   +2 B │ 464.6 KiB │ 464.6 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
    total │  29.2 MiB │  29.2 MiB │ +702 B │  80.6 MiB │  80.6 MiB │ +3 KiB 

@ahmedre ahmedre added this pull request to the merge queue Dec 28, 2024
Merged via the queue into main with commit 1ec2a9e Dec 28, 2024
2 checks passed
@ahmedre ahmedre deleted the fix_missing_audio_settings branch December 28, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant