Fix wrong page when switching foldable state #3039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching between folded and open states, the page would often
reset (ex from sura Nur ayah 35 in closed mode would become sura Nisa'
in open mode). This is because there are two conversions happening. By
setting isDualPages, the currentPage read is the new position, but the
code would then re-convert that page, thus breaking it. This updates it
by reading currentPage before updating isDualPages.
In the future, this code can likely be simplified (i.e. removing the
mapping in favor of just reading the most up to date page).