Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong page when switching foldable state #3039

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Fix wrong page when switching foldable state #3039

merged 1 commit into from
Dec 29, 2024

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Dec 29, 2024

When switching between folded and open states, the page would often
reset (ex from sura Nur ayah 35 in closed mode would become sura Nisa'
in open mode). This is because there are two conversions happening. By
setting isDualPages, the currentPage read is the new position, but the
code would then re-convert that page, thus breaking it. This updates it
by reading currentPage before updating isDualPages.

In the future, this code can likely be simplified (i.e. removing the
mapping in favor of just reading the most up to date page).

When switching between folded and open states, the page would often
reset (ex from sura Nur ayah 35 in closed mode would become sura Nisa'
in open mode). This is because there are two conversions happening. By
setting isDualPages, the currentPage read is the new position, but the
code would then re-convert that page, thus breaking it. This updates it
by reading currentPage before updating isDualPages.

In the future, this code can likely be simplified (i.e. removing the
mapping in favor of just reading the most up to date page).
@ahmedre ahmedre enabled auto-merge December 29, 2024 22:26
@ahmedre ahmedre added this pull request to the merge queue Dec 29, 2024
Copy link

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │          compressed           │         uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff  
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
      dex │  24.1 MiB │  24.1 MiB │ +45 B │  74.8 MiB │  74.8 MiB │ +24 B 
     arsc │   2.7 MiB │   2.7 MiB │   0 B │   2.7 MiB │   2.7 MiB │   0 B 
 manifest │   5.8 KiB │   5.8 KiB │   0 B │    28 KiB │    28 KiB │   0 B 
      res │   1.7 MiB │   1.7 MiB │  +6 B │     2 MiB │     2 MiB │   0 B 
   native │  18.8 KiB │  18.8 KiB │   0 B │  36.5 KiB │  36.5 KiB │   0 B 
    asset │ 404.2 KiB │ 404.2 KiB │   0 B │ 678.6 KiB │ 678.6 KiB │   0 B 
    other │ 218.3 KiB │ 218.4 KiB │  +8 B │ 464.6 KiB │ 464.6 KiB │   0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
    total │  29.2 MiB │  29.2 MiB │ +59 B │  80.6 MiB │  80.6 MiB │ +24 B 

Merged via the queue into main with commit 6ddf618 Dec 29, 2024
2 checks passed
@ahmedre ahmedre deleted the fix_foldables branch December 29, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant