Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OpenJDK 21 #1222

Merged
merged 11 commits into from
Dec 10, 2024
Merged

Add support for OpenJDK 21 #1222

merged 11 commits into from
Dec 10, 2024

Conversation

tresf
Copy link
Contributor

@tresf tresf commented Nov 26, 2023

Partially addresses/related #1218

@tresf
Copy link
Contributor Author

tresf commented Nov 26, 2023

CI-builds are failing. It appears that JavaFX 21 "monocle" is not released for Linux x86_64. We've filed a bug report with Gluon for this here: SUPQZ-19 (private)

@tresf tresf marked this pull request as draft November 28, 2023 19:10
@tresf
Copy link
Contributor Author

tresf commented Nov 28, 2023

CI-builds are failing. It appears that JavaFX 21 "monocle" is not released for Linux x86_64. We've filed a bug report with Gluon for this here: SUPQZ-19 (private)

Gluon is going to try to upstream the monocle features that we need into JavaFX proper, which would theoretically fix this. Since this is going to take some time, we should probably revert back to JavaFX 19 so that this PR is in a passing state and update JavaFX as a separate initiative.

Edit: They sent us an experimental release. PR opened #1225

@tresf
Copy link
Contributor Author

tresf commented Dec 10, 2024

This PR should be split up into two tasks:

  1. Update build system to support JDK21
  2. Switch build system to default to JDK21

The reasoning is that there is some uncertainty for #1225 in regards to exactly which JDK we should be targeting and the more PRs that depend on JDK21+ patches, the harder these will be to manage long-term.

@tresf tresf changed the title Update project to OpenJDK 21 Add support for OpenJDK 21 Dec 10, 2024
@tresf tresf marked this pull request as ready for review December 10, 2024 21:35
@tresf tresf merged commit b576864 into master Dec 10, 2024
12 checks passed
@tresf tresf deleted the jdk21 branch December 10, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant