Add Timezone to Cert #1292
Add Timezone to Cert #1292
Conversation
|
It is not at all obvious that the date entry is intractable, but I could not find a clean way to make it apparent. Due to how tables are implemented, we can't even do the hand-cursor to show it is interactable without a bunch of hit-detection code. |
|
When switching from EST to UTC, the selected row loses focus. This should be fixed. Also, the selection affects rows not clicked, which makes sense, but is out of context. |
Both of these are addressed in the latest code changes, thanks. After a code review, I'm concerned about the use of |
| @@ -126,7 +170,22 @@ public Component getTableCellRendererComponent(JTable table, Object value, boole | |||
|
|
|||
| // First Column | |||
| if (value instanceof CertificateField) { | |||
| label = stylizeLabel(STATUS_NORMAL, label, isSelected); | |||
There was a problem hiding this comment.
@Vzor- do you mind explaining these changes? At a glance I would not expect the first column logic to change as a result of this PR. Perhaps it was due to some unreverted changes, but I would expect this logic to be largely untouched.
There was a problem hiding this comment.
With the timezone added, the warning tag was getting cut off. I decided to move it to the left for clarity, and share the formatting color of the value, with the key.
|
@Vzor- thanks for the simplification. I've made some minor refactorings to simplify the timezone flag by stashing it in the enum field. This will have the side-effect of being remembered between reloading of certs into the table. |
Closes #1289
WIPCopy support soon to come in a separate PR.
Old:
New:
