Only use query string when input exists.

r4ds · Nov 23, 2023 · 860b84e · 860b84e
1 parent 7a091d5
commit 860b84e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/R/app_server.R b/R/app_server.R
@@ -4,19 +4,16 @@
 #' @keywords internal
 .app_server <- function(input, output, session) {
   # Set up input row.
-  cli::cli_inform("Setting up input row.")
   slack_user_info <- .user_server()
   timezone <- .timezone_server()
   selected_book <- .book_server()
 
-  cli::cli_inform("Loading signups.")
   signups <- reactive({
     .load_book_signups(selected_book())
   })
 
   # I need to sort out the reactivity to make this its own module. For now this
   # works and other attempts didn't.
-  cli::cli_inform("Setting up calendar observer.")
   observe({
     req(
       timezone(),
@@ -32,7 +29,6 @@
     )
   })
 
-  cli::cli_inform("Setting up submit observer.")
   observeEvent(
     input$submit,
     .submit_availability(

diff --git a/R/book.R b/R/book.R
@@ -29,12 +29,16 @@
       query_book <- book_choices[book_choices == query$bookname]
     })
 
-    # Only use the query_string to update the input when the app initially
-    # loads. After that, the input is the source of truth.
+    # Only use the query_string to update the input when the app initially loads
+    # AND THE UI INCLUDES THE INPUT. After that, the input is the source of
+    # truth.
     observeEvent(
       query_book(),
       {
-        if (length(query_book()) && query_book() != input$selected_book) {
+        if (
+          length(query_book()) && length(input$selected_book) &&
+          query_book() != input$selected_book
+        ) {
           updateSelectInput( # nocov start (can't find a way to automate)
             session,
             "selected_book",