Display account name when display name is blank. (#119)

* Display account name when display name is blank.

Closes #71.

* Update test to match this update.

We no longer user "display_name".

* Include real name if set.

When you DM someone, it uses display_name if set, then real_name, then name. So let's follow the same hierarchy.

R/app_server.R

@@ -32,7 +32,7 @@
   observeEvent(
     input$submit,
     .submit_availability(
-      slack_user_info()[["display_name"]],
+      slack_user_info()[["user_name"]],
       slack_user_info()[["user_id"]],
       selected_book(),
       timezone(),

R/user.R

@@ -18,19 +18,42 @@
 #' @keywords internal
 .user_server <- function(id = "user_name") {
   moduleServer(id, function(input, output, session) {
-    slack_user_info <- .shinyslack_user_info(c("display_name", "user_id"))
+    user_info <- .bookclubber_user_info()
     output$user_name <- renderText(
       paste(
         strong("Logged in as"),
         br(),
-        slack_user_info()[["display_name"]]
+        user_info()[["user_name"]]
       )
     )
-    return(slack_user_info)
+    return(user_info)
   })
 }
 
+.bookclubber_user_info <- function() {
+  slack_user_info <- .shinyslack_user_info(
+    c("user_id", "display_name", "real_name", "user_name")
+  )
+  return(
+    shiny::reactive({
+      list(
+        user_id = slack_user_info()[["user_id"]],
+        user_name = slack_user_info()[["display_name"]] %|"|%
+          slack_user_info()[["real_name"]] %|"|%
+          slack_user_info()[["user_name"]]
+      )
+    })
+  )
+}
+
 # Abstract for mocking.
 .shinyslack_user_info <- function(components) {
   shinyslack::user_info(components) # nocov
 }
+
+`%|"|%` <- function(x, y) {
+  if (is.null(x) || !isTRUE(as.logical(nchar(x)))) {
+    return(y)
+  }
+  return(x)
+}

tests/testthat/test-user.R

@@ -17,7 +17,7 @@ test_that("user server builds expected output", {
 })
 
 test_that("user server returns expected object", {
-  test_user_info <- list(display_name = "test_user", user_id = "test_user_id")
+  test_user_info <- list(user_id = "test_user_id", user_name = "test_user")
   local_mocked_bindings(
     .shinyslack_user_info = function(components) {
       # Return a function to simulate a reactive.