khepri_cluster: Unify members() and nodes() with other query APIs
#300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why] It will be easier to work with the `members()` and `nodes()` functions if they take the same arguments as queries of the store. [How] The `Timeout` argument is replaced with a map of query options, the same as store queries. It supports the `timeout` and `favor` options. In particular, the `favor` option indicates if the query should be sent to the leader or the local Ra server. The `locally_known_*()` variants became irrelevant and were deleted.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
==========================================
+ Coverage 89.54% 89.57% +0.02%
==========================================
Files 22 22
Lines 3263 3251 -12
==========================================
- Hits 2922 2912 -10
+ Misses 341 339 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
the-mikedavis
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It will be easier to work with the
khepri_cluster:members()andkhepri_cluster:nodes()functions if they take the same arguments as queries of the store.How
The
Timeoutargument is replaced with a map of query options, the same as store queries. It supports thetimeoutandfavoroptions. In particular, thefavoroption indicates if the query should be sent to the leader or the local Ra server.The
khepri_cluster:locally_known_*()variants became irrelevant and were deleted.