Implementing Connection, Management and Publisher modules #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielePalaia
force-pushed
the
connection_layer
branch
from
8820d8a to
9e7bec5
Compare
Signed-off-by: Gabriele Santomaggio <[email protected]>
DanielePalaia
force-pushed
the
connection_layer
branch
6 times, most recently
from
a51797f to
2736559
Compare
DanielePalaia
force-pushed
the
connection_layer
branch
from
2736559 to
078ca17
Compare
DanielePalaia
force-pushed
the
connection_layer
branch
from
a4a15c8 to
17fe614
Compare
DanielePalaia
force-pushed
the
connection_layer
branch
from
17fe614 to
4a953c7
Compare
Gsantomaggio
reviewed
Jan 9, 2025
There was a problem hiding this comment.
In general looks good as first version.
May I ask to have a look https://github.com/rabbitmq/rabbitmq-amqp-dotnet-client/blob/main/Tests/Management/ManagementTests.cs to see if this client covers all the management cases?
DanielePalaia
force-pushed
the
connection_layer
branch
4 times, most recently
from
63f03e3 to
da0856c
Compare
DanielePalaia
force-pushed
the
connection_layer
branch
2 times, most recently
from
e874173 to
37570f2
Compare
DanielePalaia
force-pushed
the
connection_layer
branch
from
37570f2 to
078b70d
Compare
|
As I'm extending the unit tests, I'm realizing that the arguments for queues and exchanges are not managed well and needs improvements. I'll work on it |
DanielePalaia
force-pushed
the
connection_layer
branch
5 times, most recently
from
83dce6e to
5ceedca
Compare
DanielePalaia
force-pushed
the
connection_layer
branch
3 times, most recently
from
08adb16 to
f05c54e
Compare
DanielePalaia
force-pushed
the
connection_layer
branch
5 times, most recently
from
6ac9a41 to
f80773d
Compare
DanielePalaia
force-pushed
the
connection_layer
branch
from
f80773d to
ecbc423
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1
This closes #4
This closes #5
This closes #6
This PR provides a connection layer to dial the AMQP server and to create a Sender and Receiver objects.
it also implements the various management operations: declare_queue, declare_exchange, bind/unbind, purge_queue, delete_queue, delete_exchange.
It also implements the Publisher layer to send messages to exchanges and/or queues.
We are avoiding using Interfaces for the various layers: binding ,exchanges, queues ecc... as it was suggested for the GO implementation
We are importing the qpid library code in order to treat a special case when we encode an empty body message.
See: #1. The library is imported in qpid/proton and I think we can avoid reviewing that original code
An example is provided in examples/getting_started/main.py