Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for missing Data Manager 0 #30

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

keflavich
Copy link
Contributor

Fix for Issue #29.

Open to suggestions on better ways to interact with iterators here.

ordered dictionary keys not being iterable...
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2021

Codecov Report

Merging #30 (89d4a73) into main (987cca5) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   55.39%   55.43%   +0.04%     
==========================================
  Files          16       16              
  Lines        2094     2096       +2     
==========================================
+ Hits         1160     1162       +2     
  Misses        934      934              
Impacted Files Coverage Δ
...asa_formats_io/casa_low_level_io/casa_functions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 987cca5...89d4a73. Read the comment docs.

@astrofrog
Copy link
Member

I'm not sure how the casa functions behave when there are more than one data manager but this seems sensible in principle.

@keflavich
Copy link
Contributor Author

OK, if you think it's reasonable, let's merge it?

@keflavich keflavich requested a review from astrofrog November 19, 2021 01:34
@astrofrog astrofrog merged commit 100ee40 into radio-astro-tools:main Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants