Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more santizining #11

Merged
merged 1 commit into from
Jul 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions ossc.php
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ public static function settings_link( array $links ): array {
}

private static function determine_option( string|array $attrs, string $option ): string {
if ( isset( $_POST['ossc_nonce'] ) && wp_verify_nonce( $_POST['ossc_nonce'], 'ossc_action' ) ) {
if ( isset( $_POST['ossc_nonce'] ) && wp_verify_nonce( sanitize_text_field( wp_unslash( $_POST['ossc_nonce'] ) ), 'ossc_action' ) ) {
if ( isset( $_POST[ $option ] ) ) {
// Form data option
return sanitize_text_field( strtolower( $_POST[ $option ] ) );
Expand Down Expand Up @@ -243,11 +243,17 @@ public function render_ossc( string|array $attrs = [] ): string {
$table_name = $wpdb->prefix . 'ossc_github_data';
$content = '<div class="ossc_div">';

$github_repos = explode( ',', get_option( 'github_repos' ) );
$github_repos_option = sanitize_textarea_field( get_option( 'github_repos' ) )

if ( ! empty( $github_repos_option ) ) {
$github_repos = array_map( 'trim', explode( ',', $github_repos_option ) );
} else {
$github_repos = [];
}

foreach ( $github_repos as $repo ) {
$repo_name = explode( '/', $repo )[1] ?? '';
$content .= '<p><strong><a href="https://github.com/' . $repo . '" target="_blank" data-type="URL" rel="noreferrer noopener">' . $repo_name . '</a></strong></p>';
$content .= '<p><strong><a href="https://github.com/' . esc_url( $repo ) . '" target="_blank" data-type="URL" rel="noreferrer noopener">' . $repo_name . '</a></strong></p>';
$results = $wpdb->get_results( $wpdb->prepare( 'SELECT * FROM %i WHERE repo = %s ORDER BY closed_at DESC', $table_name, $repo ), ARRAY_A ); // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching
$content .= '<ul class="ossc_ul">';
foreach ( $results as $item ) {
Expand All @@ -263,8 +269,10 @@ public function render_ossc( string|array $attrs = [] ): string {
public function fetch_and_save_github_data(): array|bool {
global $wpdb;
$table_name = $wpdb->prefix . 'ossc_github_data';
$github_repos = array_values( array_unique( explode( ',', get_option( 'github_repos' ) ) ) );
$github_users = array_values( array_unique( explode( ',', get_option( 'github_users' ) ) ) );
$github_repos_option = sanitize_textarea_field( get_option( 'github_repos' ) );
$github_users_option = sanitize_textarea_field( get_option( 'github_users' ) );
$github_repos = array_values( array_unique( array_map( 'trim', explode( ',', $github_repos_option ) ) ) );
$github_users = array_values( array_unique( array_map( 'trim', explode( ',', $github_users_option ) ) ) );
$errors = [];

foreach ( $github_repos as $repo ) {
Expand Down Expand Up @@ -326,7 +334,7 @@ private function github_pull_requests( string $repo, ?array $users = null ): arr
$httpcode = wp_remote_retrieve_response_code( $results );
$response_message = wp_remote_retrieve_response_message( $results );
if ( 200 != $httpcode && 302 != $httpcode && 304 != $httpcode && ! empty( $response_message ) ) {
return 'Problem Connecting to Server! : ' . $response_message;
return 'Problem Connecting to Server! : ' . $response_message . ' URL: ' . $url;
}
$body = wp_remote_retrieve_body( $results );
$data = json_decode( $body, true );
Expand Down Expand Up @@ -355,7 +363,7 @@ private function get_next_page_url_from_link_header( string $link_header ): stri
}

private function get( string $url ): array|WP_Error {
$github_api_key = get_option( 'github_api_key' );
$github_api_key = sanitize_text_field( get_option( 'github_api_key' ) );

$args = [
'timeout' => '120',
Expand Down
13 changes: 13 additions & 0 deletions readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,19 @@ EXAMPLES

<a href="https://radiusmethod.com/oss/">https://radiusmethod.com/oss/</a>

### Third-Party Service Disclosure

This plugin relies on a third-party service, GitHub API, to function properly. The plugin fetches data from GitHub API under the following circumstances:

- When retrieving merged pull requests data to display within the application.

## Service Information

- **Service Used:** GitHub API
- **API Endpoint:** [GitHub API Documentation](https://docs.github.com/en/rest/reference/pulls)
- **Terms of Use:** [GitHub Terms of Service](https://docs.github.com/en/github/site-policy/github-terms-of-service)
- **Privacy Policy:** [GitHub Privacy Statement](https://docs.github.com/en/github/site-policy/github-privacy-statement)

MORE INFORMATION

<a href="https://github.com/radiusmethod/ossc-wp" target="_blank">https://github.com/radiusmethod/ossc-wp</a>
Expand Down