Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SwiftFormat #284

Merged
merged 5 commits into from
Nov 29, 2024
Merged

Add SwiftFormat #284

merged 5 commits into from
Nov 29, 2024

Conversation

matiasbzurovski
Copy link
Contributor

@matiasbzurovski matiasbzurovski commented Nov 29, 2024

Adds SwiftFormat support. As you can see on first commit ac5b834, it follows the same rules than iOS Wallet.

Latest commit 6841af4 is the application of the format to existent files, which is what adds all the file changes.

@matiasbzurovski matiasbzurovski added the Swift 🍏 Changes in Swift Sargon label Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 91.24088% with 48 lines in your changes missing coverage. Please review.

Project coverage is 93.2%. Comparing base (9d5d641) to head (18a0b26).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...Methods/RET/SubintentManifest+Wrap+Functions.swift 0.0% 13 Missing ⚠️
...s/Crypto/Derivation/BIP32/U30+Wrap+Functions.swift 0.0% 6 Missing ⚠️
...ensions/Methods/RET/Subintent+Wrap+Functions.swift 0.0% 6 Missing ⚠️
...oWalletInteractionUnvalidated+Wrap+Functions.swift 0.0% 4 Missing ⚠️
...o/Derivation/BIP32/Securified+Wrap+Functions.swift 80.0% 3 Missing ⚠️
...s/Crypto/Derivation/BIP32/U31+Wrap+Functions.swift 50.0% 3 Missing ⚠️
...on/BIP32/UnsecurifiedHardened+Wrap+Functions.swift 80.0% 3 Missing ⚠️
...thods/RadixConnect/Mobile/RadixConnectMobile.swift 0.0% 3 Missing ⚠️
.../Derivation/BIP32/HdPathComponent+Swiftified.swift 66.6% 3 Missing ⚠️
...eSystem/FileSystemDriver+Data+ContentsOf+URL.swift 90.4% 2 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #284     +/-   ##
=======================================
- Coverage   93.2%   93.2%   -0.1%     
=======================================
  Files       1079    1079             
  Lines      21588   21583      -5     
  Branches      77      77             
=======================================
- Hits       20128   20123      -5     
  Misses      1446    1446             
  Partials      14      14             
Flag Coverage Δ
kotlin 98.0% <ø> (ø)
rust 92.0% <ø> (ø)
swift 97.6% <91.2%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/EntropyProvider/EntropyProvider+RandomData.swift 100.0% <100.0%> (ø)
...ple/Sources/Sargon/Drivers/EventBus/EventBus.swift 100.0% <100.0%> (ø)
...rivers/EventBus/EventNotification+Swiftified.swift 100.0% <100.0%> (ø)
...n/Drivers/HostInfo/HostInfoDriver+DeviceInfo.swift 97.1% <100.0%> (-0.1%) ⬇️
...argon/Drivers/Logging/LoggingDriver+SwiftLog.swift 100.0% <100.0%> (ø)
...ivers/Networking/NetworkingDriver+URLSession.swift 83.3% <ø> (ø)
...rivers/ProfileStateChange/ProfileStateChange.swift 100.0% <100.0%> (ø)
...iver+InsecureTestOnlyEphemeral_SecureStorage.swift 100.0% <ø> (ø)
...urces/Sargon/Drivers/TestDrivers/TestDrivers.swift 100.0% <100.0%> (ø)
...safeStorage/UnsafeStorageDriver+UserDefaults.swift 100.0% <ø> (ø)
... and 163 more

... and 69 files with indirect coverage changes

Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matiasbzurovski matiasbzurovski merged commit d016d67 into main Nov 29, 2024
12 of 13 checks passed
@matiasbzurovski matiasbzurovski deleted the swift-format branch November 29, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Swift 🍏 Changes in Swift Sargon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants