Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SecurityProblemKind::SecurityShields #295

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

matiasbzurovski
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.3%. Comparing base (730f216) to head (7ea873b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #295   +/-   ##
=====================================
  Coverage   93.3%   93.3%           
=====================================
  Files       1093    1093           
  Lines      22855   22855           
  Branches      77      77           
=====================================
  Hits       21328   21328           
  Misses      1513    1513           
  Partials      14      14           
Flag Coverage Δ
kotlin 97.9% <ø> (ø)
rust 92.7% <ø> (ø)
swift 95.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...argon/src/security_center/security_problem_kind.rs 100.0% <ø> (ø)

Copy link
Contributor

@Sajjon Sajjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Feel free to merge if you can

@Sajjon
Copy link
Contributor

Sajjon commented Dec 6, 2024

Lgtm, feel free to merge if you can

@matiasbzurovski
Copy link
Contributor Author

@Sajjon need 1 approval :)

@Sajjon
Copy link
Contributor

Sajjon commented Dec 6, 2024

Why I said "if you can" ☺️(bypass check). Else will approve from work phone in ~5min. Dont have it on my atm

Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matiasbzurovski matiasbzurovski merged commit f88548e into main Dec 6, 2024
13 checks passed
@matiasbzurovski matiasbzurovski deleted the mb/problem-type-fix branch December 6, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants