Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special handling for virtual accounts #301

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

matiasbzurovski
Copy link
Contributor

Changelog

When implementing the delete account feature, we need to add in #268 special handling for 2 methods (fetch_all_account_resource_preferences & fetch_all_account_authorized_depositors) since their respective endpoints would return a 404 for virtual accounts.

This was fixed by the Gateway team, so such handling is no longer necessary. This integration test confirms it still works fine after the changes 🙂

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.3%. Comparing base (723d183) to head (fe1132e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #301   +/-   ##
=====================================
  Coverage   93.2%   93.3%           
=====================================
  Files       1095    1095           
  Lines      22930   22922    -8     
  Branches      77      77           
=====================================
- Hits       21389   21387    -2     
+ Misses      1527    1521    -6     
  Partials      14      14           
Flag Coverage Δ
kotlin 97.9% <ø> (ø)
rust 92.7% <100.0%> (+<0.1%) ⬆️
swift 94.9% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...es/sargon/src/gateway_api/methods/state_methods.rs 81.0% <100.0%> (+2.2%) ⬆️
...s/sargon/src/system/sargon_os/sargon_os_signing.rs 64.8% <ø> (ø)

@matiasbzurovski matiasbzurovski merged commit 217f10a into main Dec 10, 2024
13 checks passed
@matiasbzurovski matiasbzurovski deleted the remove-special-handling-virtual-accounts branch December 10, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants