Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entities linked to Factor Source #302

Merged
merged 17 commits into from
Dec 13, 2024

updated Fakes in unit tests

46d9069
Select commit
Loading
Failed to load commit list.
Merged

Entities linked to Factor Source #302

updated Fakes in unit tests
46d9069
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 13, 2024 in 0s

93.2% (-0.1%) compared to 56c6e58

View this Pull Request on Codecov

93.2% (-0.1%) compared to 56c6e58

Details

Codecov Report

Attention: Patch coverage is 87.11656% with 21 lines in your changes missing coverage. Please review.

Project coverage is 93.2%. Comparing base (56c6e58) to head (46d9069).

Files with missing lines Patch % Lines
...ent/unsafe_storage_client/unsafe_storage_client.rs 77.2% 5 Missing ⚠️
...iver+InsecureTestOnlyEphemeral_SecureStorage.swift 0.0% 3 Missing ⚠️
...n_os/sargon_os_entities_linked_to_factor_source.rs 90.9% 3 Missing ⚠️
...ixdlt/sargon/os/storage/key/ByteArrayKeyMapping.kt 0.0% 2 Missing and 1 partial ⚠️
...ava/com/radixdlt/sargon/os/storage/StorageUtils.kt 0.0% 2 Missing ⚠️
...torage/key/DeviceFactorSourceMnemonicKeyMapping.kt 0.0% 2 Missing ⚠️
...ent/secure_storage_client/secure_storage_client.rs 80.0% 1 Missing ⚠️
...radixdlt/sargon/os/storage/key/HostIdKeyMapping.kt 0.0% 1 Missing ⚠️
...sargon/os/storage/key/ProfileSnapshotKeyMapping.kt 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #302     +/-   ##
=======================================
- Coverage   93.3%   93.2%   -0.1%     
=======================================
  Files       1098    1104      +6     
  Lines      23129   23283    +154     
  Branches      77      79      +2     
=======================================
+ Hits       21582   21717    +135     
- Misses      1533    1551     +18     
- Partials      14      15      +1
Files with missing lines Coverage Δ
...urces/Sargon/Drivers/TestDrivers/TestDrivers.swift 100.0% <100.0%> (ø)
...safeStorage/UnsafeStorageDriver+UserDefaults.swift 95.8% <100.0%> (+2.0%) ⬆️
...sions/Swiftified/System/BIOS/BIOS+Swiftified.swift 100.0% <100.0%> (ø)
...Swiftified/System/Drivers/Drivers+Swiftified.swift 100.0% <100.0%> (ø)
apple/Sources/Sargon/SargonOS/TestOS.swift 47.3% <100.0%> (+1.4%) ⬆️
...n/src/profile/logic/account/accounts_visibility.rs 100.0% <100.0%> (ø)
...sargon/src/profile/logic/account/query_accounts.rs 95.4% <100.0%> (+0.2%) ⬆️
...sargon/src/profile/logic/persona/query_personas.rs 100.0% <100.0%> (ø)
...rofile_network_entities_linked_to_factor_source.rs 100.0% <100.0%> (ø)
...ic/profile_network/profile_network_get_entities.rs 100.0% <100.0%> (ø)
... and 16 more

... and 1 file with indirect coverage changes

View more details on Codecov