Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIP: Support mix of Accounts & Personas #306

Merged
merged 66 commits into from
Dec 20, 2024

review polish

ee84209
Select commit
Loading
Failed to load commit list.
Merged

FIP: Support mix of Accounts & Personas #306

review polish
ee84209
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 20, 2024 in 0s

93.3% (+0.0%) compared to c4ed26a

View this Pull Request on Codecov

93.3% (+0.0%) compared to c4ed26a

Details

Codecov Report

Attention: Patch coverage is 93.69863% with 46 lines in your changes missing coverage. Please review.

Project coverage is 93.3%. Comparing base (c4ed26a) to head (ee84209).

Files with missing lines Patch % Lines
...ces_provider/provider/factor_instances_provider.rs 92.6% 12 Missing ⚠️
.../sargon/src/system/sargon_os/sargon_os_accounts.rs 85.4% 9 Missing ⚠️
...rgon/src/profile/v100/entity/has_security_state.rs 72.2% 5 Missing ⚠️
...provider/factor_instances_cache/keyed_instances.rs 0.0% 4 Missing ⚠️
...r/factor_instances_cache/factor_instances_cache.rs 98.1% 2 Missing ⚠️
...come/internal_factor_instances_provider_outcome.rs 94.7% 2 Missing ⚠️
...pters/securify_entity_factor_instances_provider.rs 83.3% 2 Missing ⚠️
...actor_instance_level/role_with_factor_instances.rs 33.3% 2 Missing ⚠️
...c/profile/v100/networks/network/profile_network.rs 84.6% 2 Missing ⚠️
...rgon/src/profile/v100/networks/profile_networks.rs 50.0% 2 Missing ⚠️
... and 3 more
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##            main    #306    +/-   ##
======================================
  Coverage   93.3%   93.3%            
======================================
  Files       1110    1111     +1     
  Lines      23595   24043   +448     
  Branches      79      79            
======================================
+ Hits       22025   22445   +420     
- Misses      1555    1583    +28     
  Partials      15      15
Files with missing lines Coverage Δ
crates/sargon/src/core/error/common_error.rs 93.3% <ø> (ø)
...n/src/core/types/keys/key_agreement/private_key.rs 100.0% <ø> (ø)
...ances_provider/agnostic_paths/derivation_preset.rs 100.0% <100.0%> (ø)
...ces_provider/agnostic_paths/index_agnostic_path.rs 98.6% <100.0%> (+<0.1%) ⬆️
...or_instances_provider/agnostic_paths/quantities.rs 100.0% <100.0%> (ø)
...ivation_entity_index_profile_analyzing_assigner.rs 100.0% <100.0%> (ø)
..._derivation_entity_index_with_ephemeral_offsets.rs 100.0% <ø> (ø)
...vider/outcome/factor_instances_provider_outcome.rs 100.0% <100.0%> (ø)
...al_factor_instances_provider_outcome_for_factor.rs 100.0% <100.0%> (ø)
...rovider/provider/provider_adopters/cache_filler.rs 97.4% <100.0%> (+1.7%) ⬆️
... and 44 more

... and 1 file with indirect coverage changes

View more details on Codecov