Propagate compile diagnostics #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhenadieVP
force-pushed
the
propaget_better_errors
branch
from
2ccf1cc to
9014cdc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
=====================================
Coverage 93.3% 93.3%
=====================================
Files 1111 1111
Lines 24182 24193 +11
Branches 79 79
=====================================
+ Hits 22570 22581 +11
Misses 1597 1597
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
CyonAlexRDX
reviewed
Dec 23, 2024
| ); | ||
| } | ||
|
|
||
| #[test] | ||
| fn extract_error_from_error_non_gen_err() { | ||
| assert_eq!( | ||
| CommonError::from_scrypto_compile_error( | ||
| "invalid_manifest", |
There was a problem hiding this comment.
"this is a super duper invalid manifest" is more clear a test string IMO.
There was a problem hiding this comment.
because at first I thought this was suppose to match some expected enum value or so
sergiupuhalschi-rdx
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate pretty diagnostics error for CompileError. This will help dApp developers to understand better the reason when a manifest is invalid.