Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out Addresses and KeysCollector into separate crates #325

Merged

Conversation

CyonAlexRDX
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX commented Dec 30, 2024

Note

Target branch is not main

@CyonAlexRDX CyonAlexRDX changed the title Ac/split 04 addresses and keyscollector Split out Addresses and KeysCollector into separate crates Dec 30, 2024
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 93.58974% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.1%. Comparing base (fe4adac) to head (9031a50).

Files with missing lines Patch % Lines
.../test_keys_collector/test_derivation_interactor.rs 87.5% 3 Missing ⚠️
...argon/src/types/samples/account_address_samples.rs 50.0% 1 Missing ⚠️
...rgon/src/types/samples/identity_address_samples.rs 50.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           ac/split-03-factors    #325    +/-   ##
====================================================
  Coverage                 93.1%   93.1%            
====================================================
  Files                     1118    1122     +4     
  Lines                    24508   24781   +273     
  Branches                    79      79            
====================================================
+ Hits                     22831   23091   +260     
- Misses                    1662    1675    +13     
  Partials                    15      15            
Flag Coverage Δ
kotlin 97.1% <ø> (ø)
rust 92.6% <93.5%> (+<0.1%) ⬆️
swift 94.8% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...addresses/src/address/access_controller_address.rs 100.0% <ø> (ø)
...es/sargon-addresses/src/address/account_address.rs 73.6% <100.0%> (ø)
...tes/sargon-addresses/src/address/address_format.rs 0.0% <ø> (ø)
...esses/src/address/address_of_account_or_persona.rs 100.0% <ø> (ø)
...ates/sargon-addresses/src/address/address_union.rs 100.0% <ø> (ø)
.../sargon-addresses/src/address/component_address.rs 100.0% <ø> (ø)
...tes/sargon-addresses/src/address/entity_address.rs 100.0% <ø> (ø)
...s/sargon-addresses/src/address/identity_address.rs 100.0% <ø> (ø)
...sses/src/address/legacy_olympia_account_address.rs 93.1% <ø> (ø)
...tes/sargon-addresses/src/address/locker_address.rs 100.0% <ø> (ø)
... and 48 more

@CyonAlexRDX CyonAlexRDX marked this pull request as ready for review December 30, 2024 08:13
@CyonAlexRDX CyonAlexRDX merged commit 7178fe5 into ac/split-03-factors Dec 30, 2024
10 of 11 checks passed
@CyonAlexRDX CyonAlexRDX deleted the ac/split-04-addresses-and-keyscollector branch December 30, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants