Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out Profile, Gateway, FIP, Drivers, Clients, Manifest building and TX models #326

Merged
merged 23 commits into from
Jan 2, 2025

Conversation

CyonAlexRDX
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX commented Jan 1, 2025

Note

Target branch is not main

Important

the large git diff comes from many Cargo locks files from all new crates primary

New crates:

  • sargon-factors-supporting-types
  • sargon-transaction-models
  • sargon-manifests
  • sargon-profile-supporting-types
  • sargon-drivers
  • http-client
  • sargon-clients
  • sargon-profile-gateway
  • sargon-profile
  • sargon-profile-app-preferences
  • sargon-profile-security-structures
  • sargon-profile-logic
  • sargon-factor-instances-provider
  • next-derivation-index-ephemeral
  • gateway-models
  • gateway-logic
  • gateway-client-and-api

@CyonAlexRDX CyonAlexRDX changed the title Ac/split profile fip Split out Profile, Gateway, FIP, Drivers, Clients, Manifest building and TX models Jan 1, 2025
@CyonAlexRDX
Copy link
Contributor Author

Whenever CI for Swift and Kotlin (and rust unit test) pass, this PR ought to be merged. And then we should merge #318

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 96.94656% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.0%. Comparing base (81aef4b) to head (2ff58f0).
Report is 1 commits behind head on ac/split.

Files with missing lines Patch % Lines
...ay-client-and-api/src/endpoints/state_endpoints.rs 75.0% 2 Missing ⚠️
...nt/factor_instances_cache_client/models/outcome.rs 95.2% 1 Missing ⚠️
...n-factors-supporting-types/src/mnemonic_loading.rs 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           ac/split    #326     +/-   ##
==========================================
- Coverage      93.1%   93.0%   -0.2%     
==========================================
  Files          1122    1128      +6     
  Lines         24781   25416    +635     
  Branches         79      79             
==========================================
+ Hits          23091   23657    +566     
- Misses         1675    1744     +69     
  Partials         15      15             
Flag Coverage Δ
kotlin 97.1% <ø> (ø)
rust 92.5% <96.9%> (-0.2%) ⬇️
swift 94.8% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ransaction/AccountOrAddressOf+Wrap+Functions.swift 100.0% <ø> (ø)
...ed/Transaction/AccountOrAddressOf+Swiftified.swift 100.0% <ø> (ø)
...teway-client-and-api/src/assert_network_request.rs 100.0% <ø> (ø)
...ateway-client-and-api/src/client/gateway_client.rs 100.0% <100.0%> (ø)
...-api/src/client/gateway_client_dispatch_request.rs 80.0% <100.0%> (ø)
...y-client-and-api/src/endpoints/status_endpoints.rs 100.0% <100.0%> (ø)
...ent-and-api/src/endpoints/transaction_endpoints.rs 93.7% <100.0%> (ø)
...gateway-client-and-api/src/methods/page_methods.rs 100.0% <ø> (ø)
...ateway-client-and-api/src/methods/state_methods.rs 81.0% <ø> (ø)
...-client-and-api/src/methods/transaction_methods.rs 100.0% <ø> (ø)
... and 115 more

... and 520 files with indirect coverage changes

@CyonAlexRDX CyonAlexRDX merged commit 1b27e20 into ac/split Jan 2, 2025
12 of 13 checks passed
@CyonAlexRDX CyonAlexRDX deleted the ac/split-profile-fip branch January 2, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants