Add json serialize/deserialize for factorsourceid #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
=======================================
Coverage 92.01% 92.02%
=======================================
Files 1152 1152
Lines 25675 25678 +3
Branches 85 85
=======================================
+ Hits 23626 23629 +3
Misses 2034 2034
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
micbakos-rdx
approved these changes
Jan 8, 2025
|
@giannis-rdx you need to rebase |
giannis-rdx
force-pushed
the
task/json-factorsourceid
branch
from
1293e9e to
f594231
Compare
Sajjon
reviewed
Jan 8, 2025
crates/sargon/Cargo.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "sargon" | |||
| version = "1.1.100" | |||
| version = "1.1.101" | |||
There was a problem hiding this comment.
Hmm this is wrong, you should bump ALL 60 crates with the make bump command
Which requires cargo workspace:
https://crates.io/crates/cargo-workspaces so install that first
There was a problem hiding this comment.
well the version-check failed because it bumped from 100 to 102 (that happened because i had already manually bumped the two crates to 101) but I think after we merge this, then the check-version will succeed if I rebase and run it again, right?
CyonAlexRDX
approved these changes
Jan 9, 2025
giannis-rdx
force-pushed
the
task/json-factorsourceid
branch
from
c8401a8 to
9dd0837
Compare
[email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] Generated by cargo-workspaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Android we need to pass as a string parameter the
FactorSourceIDin the navigation, so I added support to serialize/deserialize theFactorSourceID