Add word count in off device mnemonic hint #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbakos-rdx
requested review from
CyonAlexRDX,
GhenadieVP,
giannis-rdx,
danvleju-rdx,
sergiupuhalschi-rdx and
matiasbzurovski
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
==========================================
+ Coverage 92.51% 92.54% +0.03%
==========================================
Files 1152 1152
Lines 25583 25587 +4
Branches 85 85
==========================================
+ Hits 23667 23680 +13
+ Misses 1901 1896 -5
+ Partials 15 11 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
giannis-rdx
approved these changes
Jan 9, 2025
| pub struct OffDeviceMnemonicHint { | ||
| /// A user-assigned name for the passphrase, intended to help users | ||
| /// differentiate between multiple passphrases. | ||
| pub label: DisplayName, | ||
|
|
||
| /// The number of words the `OffDeviceMnemonic`, intended to help the host provide the correct |
There was a problem hiding this comment.
Suggested change
| /// The number of words the `OffDeviceMnemonic`, intended to help the host provide the correct | |
| /// The number of words the `OffDeviceMnemonic` has, intended to help the host provide the correct |
matiasbzurovski
approved these changes
Jan 10, 2025
| @@ -8,4 +8,7 @@ pub struct OffDeviceMnemonicHint { | |||
| /// A user-assigned name for the passphrase, intended to help users | |||
| /// differentiate between multiple passphrases. | |||
| pub label: DisplayName, | |||
| /// The number of words the `OffDeviceMnemonic`, intended to help the host provide the correct | |||
There was a problem hiding this comment.
Suggested change
| /// The number of words the `OffDeviceMnemonic`, intended to help the host provide the correct | |
| /// The number of words the `OffDeviceMnemonic` has, intended to help the host provide the correct |
[email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] Generated by cargo-workspaces
micbakos-rdx
force-pushed
the
micbakos/word-count-off-device-mnemonic
branch
from
94ac0e7 to
c1ffa7f
Compare
GhenadieVP
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
word_count. Decided to not call itmnemonic_word_countas inDeviceFactorSourceHintsince the mnemonic is implied by the struct's name.Update:
Kotlinised some factor source samples.