-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish early mono sign when skipping factor #342
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
=======================================
Coverage 92.84% 92.84%
=======================================
Files 1160 1160
Lines 25797 25815 +18
Branches 85 85
=======================================
+ Hits 23952 23969 +17
- Misses 1834 1835 +1
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
18e54c3
to
6a6e3ba
Compare
6a6e3ba
to
9cab818
Compare
} | ||
|
||
pub fn prudent_with_skips(simulated_skips: SimulatedSkips) -> Self { | ||
Self::new(SimulatedUserMode::Prudent, None, simulated_skips) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prudent
means "never skips". So this looks wrong. Better let this be ctor of Lazy
. And update definition of Lazy:
- /// Emulation of a "lazy" user, that skips signing with as many factor
- /// sources as possible.
+ /// Emulation of a "lazy" user, that skips signing with as some factor
+ /// sources, depending on `Laziness`.
Lazy(Laziness),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but Laziness
has no option to sign all the rest of the factor sources except the ones defined in simulated_skips
. This is what I wanted to achieve.
Lazyness describes a user that either skips all all or signs the minimum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes so we update Laziness enum with a third variant..?
SkipsSpecific(IndexSet<_>)
[email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] Generated by cargo-workspaces
9cab818
to
c3fdaf8
Compare
Latest changes:
|
Updated mono sign, to return no request when there are no remaining per transaction requests. When a user skips a factor source, the signature collector will iterate to the next factor source. There if there are no more remaining still to be signed as valid transactions, the iterator continues. This ends up ending the collector's signing process, with an unsuccessful outcome.