Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shield builder primary role validation #353

Merged

Conversation

sergiupuhalschi-rdx
Copy link
Contributor

This PR updates the shield builder validation logic by introducing two key updates:

  1. Factor Source Selection: It now allows adding the same factor source for both the threshold and override lists in the primary role.
  2. Multiple Device Selection: It supports adding multiple devices within the primary role.

The validate() function has been updated to continue reflecting that these rules violations and therefore making the shield status Weak with the corresponding underlying reason.

@sergiupuhalschi-rdx sergiupuhalschi-rdx self-assigned this Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.68%. Comparing base (40da3cf) to head (45bf862).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...matrices_structures/roles/builder/roles_builder.rs 73.33% 4 Missing ⚠️
...ructures/security_shield_builder_rule_violation.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
- Coverage   92.68%   92.68%   -0.01%     
==========================================
  Files        1166     1166              
  Lines       26078    26084       +6     
  Branches       81       81              
==========================================
+ Hits        24171    24175       +4     
- Misses       1896     1898       +2     
  Partials       11       11              
Flag Coverage Δ
kotlin 97.73% <ø> (ø)
rust 92.18% <87.50%> (-0.01%) ⬇️
swift 93.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiupuhalschi-rdx sergiupuhalschi-rdx marked this pull request as ready for review January 23, 2025 07:16
Copy link
Contributor

@GhenadieVP GhenadieVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This reverts commit 2b82454.
@sergiupuhalschi-rdx sergiupuhalschi-rdx merged commit 5766453 into main Jan 23, 2025
11 of 13 checks passed
@sergiupuhalschi-rdx sergiupuhalschi-rdx deleted the feature/shield-building-primary-role-validation branch January 23, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants