Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things to improve/fix/refactor based on our latest changes #1135

Open
2 of 3 tasks
findolor opened this issue Jan 9, 2025 · 0 comments
Open
2 of 3 tasks

Things to improve/fix/refactor based on our latest changes #1135

findolor opened this issue Jan 9, 2025 · 0 comments
Assignees
Labels

Comments

@findolor
Copy link
Collaborator

findolor commented Jan 9, 2025

We are moving away from Config and ConfigSource and with that we have introduced DotrainYaml and OrderbookYaml struct. With these changes we have refactored a lot of different places in our repository. There are still things to do so this issue lists some of the things that needs to be done.

Existing issues:

New issues:

  • Adding update tests DotrainYaml/OrderbookYaml that uses multiple documents to make sure the correct document is updated
  • Updating select tokens to return an empty map if select tokens could not be found in yaml
  • Adding method to return name and description for gui
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants