Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving state serialization/deserialization on DotrainOrderGui #1157

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

findolor
Copy link
Collaborator

Motivation

See issues #1135 and #1120

Solution

Serialization

  • Loop through select tokens list and save token data
  • Loop through inputs and outputs and save vault ids

Deserialization

  • Make sure token data is in select tokens list. Replace token data with new data
  • Update inputs and outputs with new vault ids

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@findolor findolor added the rust Related to rust crates label Jan 14, 2025
@findolor findolor enabled auto-merge January 16, 2025 15:29
@findolor findolor merged commit 6c55f0d into main Jan 16, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Related to rust crates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All GUI selections on top of the original .rain need to be serialisable and sharable
2 participants