Allow HMR in Rancher Components and Harvester #13051
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows HMR to trigger when changes are made to Rancher Components and Harvester by omitting the
excludes
argument fromgetWatcherIgnored()
. Watch and WatchOptions work to allow Webpack to watch files and recompile whenever they change - I don't see any benefit in excluding Rancher Components and Harvester from this process by default.As I understand, the
excludes
variable exists to control production builds; this change will only affect development.This also includes a change to clean up the
appConfig
param inshell/vue.config
.The prefix
_
is a convention to indicate that a parameter is expected, but unused within a function. We make use ofappConfig
in the default export, so we can remove the_
and supply a default value forappConfig
if nothing is passed.Areas or cases that should be tested
Areas which could experience regressions
Perhaps, we were intentionally excluding these from HMR for a reason that I'm not aware of.
Checklist